This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Update WordPressKit pod to v4.6.0 beta.1 #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Gio2018
approved these changes
Mar 10, 2020
Contributor
Gio2018
left a comment
Gio2018
left a comment
There was a problem hiding this comment.
Looks good! Please remind to change the reference to the dependency to the right version instead of a specific branch once that one is ready.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the podfile to point to the feature branch for WordPress kit.
Authenticator needs updated at the same time as WPiOS, as they both depend upon
wpkitand expect the same version to be used in WPiOS.Known issues
CircleCI podspec changes are broken on purpose. It's currently failing because the
wpxmlrpcdependency version 4.6.0-beta.1 hasn't been published to CocoaPods yet. It's set to that declaration so that runningrake dependenciesin Authenticator and WPiOS will pass.Do not merge this PR until:
wpxmlrpcpod changes have been merged to develop ✔️wpxmlrpcpodspec has been published to CocoaPods ✔️WordPressKitdependency version 4.6.0-beta.1 ✔️