Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Conversation

@ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Mar 16, 2020

Ref #wordpress-mobile/WordPress-iOS#13664

This updates the Signup and Login Magic Link confirmation screen advising the user to check their spam/junk folder.

Can be tested with WPiOS PR: wordpress-mobile/WordPress-iOS#13665

@ScoutHarris ScoutHarris added the enhancement New feature or request label Mar 16, 2020
@ScoutHarris ScoutHarris self-assigned this Mar 16, 2020
Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 change requested, then :shipit:

return NSLocalizedString("We sent you a magic signup link! Check your email on this device, and tap the link in the email to finish signing up.", comment: "Instructional text on how to open the email containing a magic link.")
}
}()
label?.text = NSLocalizedString("Check your email on this device, and tap the link in the email you receive from WordPress.com.\n\nNot seeing the email? Check your Spam or Junk Mail folder.", comment: "Instructional text on how to open the email containing a magic link.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spelling error on the design. It should say received instead of receive. Would you mind updating it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm. It makes sense to me either way; I guess it depends on how you read it. 🤷‍♂ But sure, I can change it.

@ScoutHarris ScoutHarris merged commit 2a508db into develop Mar 16, 2020
@ScoutHarris ScoutHarris deleted the issue/13664-update_magic_link_instructions branch March 16, 2020 21:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants