This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Update to Gridicons 1.0 #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindgraffiti
approved these changes
Mar 19, 2020
Contributor
Author
|
Thanks for the reminder! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the authenticator library to use the new Gridicons 1.0 framework. I've updated the podspec and Podfile (which I'll further update once the pod is released), as well as switched over to the new style method calls.
To Test
Build and run the associated WordPress-iOS PR, and ensure that the auth flow loads and that some of the icons loaded here appear correctly: wordpress-mobile/WordPress-iOS#13682