Jetpack Signup Flow pushes 3 buttons instead of present

[mindgraffiti]

Fixes #233

This PR fixes the black screen bug.

PR to test on WPiOS: wordpress-mobile/WordPress-iOS#13827

Summary

After the Jetpack install flow, the user is asked to sign in again. The LoginEmailViewController is presented, and there text and a link below the email field that says, "Don't have an account? Sign up"

Tapping the "Sign up" link pushes the 3 button view instead of presenting the 3 button view. Pushing the nav creates the black screen (seen in Figure 2 below).

Steps to Reproduce

1. Have a self-hosted site that doesn't have Jetpack connected. (This also works if you go to the site, Jetpack > and scroll to the bottom to find the "Disconnect" button and click it.)
2. Log out of the WPiOS app if you are logged in.
3. Log into the app through the self-hosted flow: Login > enter site address text link button
4. After completing the login flow, go to the Notifications tab
5. Follow the Jetpack install flow. Once it is successful, it will ask you to set up Jetpack.
6. The "Set up" Jetpack button should navigate you to the email login screen. (See Figure 1 below)
7. Tap the "Sign up" text link button.
   Expected: the 3 button view appears as an overlay to the email login screen. (See Figure 3)
   Actual: the 3 button view is pushed and the background is black.

Figure 1

Figure 2

Figure 3

[mindgraffiti]

I think this should say // no-op? Because in this context: coming from Jetpack Remote Install > Sign up > Continue with Apple, it would never call the showWPComLogin() method...right?

[ScoutHarris]

I do believe showWPComLogin is needed. It's nothing to do with Jetpack at this point, it's all about the SIWA flow.

It pertains to this logic in AppleAuthenticator:

guard !existingNonSocialAccount else {

    if existing2faAccount {
        self?.show2FA()
        return
    }

    self?.updateLoginEmail(wpcomUsername)
    self?.logInInstead()
    return
}

Basically, what happens here is if an Apple ID is used where the email has already been used on a WP account, the flow will re-direct to WP login.

[mindgraffiti]

ohhh. Nice!

[ScoutHarris]

Tested with wordpress-mobile/WordPress-iOS#13827.

[mindgraffiti]

Thanks @ScoutHarris !