Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Make sign up button the primary button on prologue screen #238

Merged
merged 3 commits into from
Apr 14, 2020
Merged

Make sign up button the primary button on prologue screen #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a232c3c
Switch the primary login prologue button to Sign Up
frosty Apr 14, 2020
f37763a
Bump podspec version
frosty Apr 14, 2020
505909b
Updated Podfile.lock
frosty Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WordPressAuthenticator.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "WordPressAuthenticator"
s.version = "1.13.0-beta.1"
s.version = "1.13.0-beta.2"
s.summary = "WordPressAuthenticator implements an easy and elegant way to authenticate your WordPress Apps."

s.description = <<-DESC
Expand Down
4 changes: 2 additions & 2 deletions WordPressAuthenticator/Signin/LoginPrologueViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,10 @@ class LoginPrologueViewController: LoginViewController {
let loginTitle = NSLocalizedString("Log In", comment: "Button title. Tapping takes the user to the login form.")
let createTitle = NSLocalizedString("Sign up for WordPress.com", comment: "Button title. Tapping begins the process of creating a WordPress.com account.")

buttonViewController.setupTopButton(title: loginTitle, isPrimary: true, accessibilityIdentifier: "Prologue Log In Button") { [weak self] in
buttonViewController.setupTopButton(title: loginTitle, isPrimary: false, accessibilityIdentifier: "Prologue Log In Button") { [weak self] in
self?.loginTapped()
}
buttonViewController.setupBottomButton(title: createTitle, isPrimary: false, accessibilityIdentifier: "Prologue Signup Button") { [weak self] in
buttonViewController.setupBottomButton(title: createTitle, isPrimary: true, accessibilityIdentifier: "Prologue Signup Button") { [weak self] in
self?.signupTapped()
}
if showCancel {
Expand Down