This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Migration to Swift 4.2 #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hey @ctarda! Please include testing instructions in PRs down the road, it would help me get set up faster. I can't get our current Swift 4.2 migration branch to play nicely with this PR. It won't build for me and I'm unable to test. Going to defer to @jleandroperez review until I'm better acquainted with Xcode 10 & Swift 4.2. |
Contributor
Author
|
@mindgraffiti Sorry about that. To test, please checkout this branch and build with Xcode 10. It should build and pass the tests |
jleandroperez
approved these changes
Sep 19, 2018
Contributor
jleandroperez
left a comment
jleandroperez
left a comment
There was a problem hiding this comment.
Looks great!!
Verified directly in this branch, and integrated with WCiOS. Thanks for doing this @ctarda !!!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to Swift 4.2 and updated dependencies to the rest of the internal pods already migrated