This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Add automated testing #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an pod lint failure cased by a warning in Lottie about implicit retain cycles.
This library doesn’t directly depend on it.
This library doesn’t directly depend on it.
jtreanor
reviewed
Jan 17, 2019
| - run: | ||
| name: Bundle install | ||
| command: bundle install --path=vendor/bundle | ||
| - run: |
Contributor
There was a problem hiding this comment.
CircleCI recommend using this step prior to running pod install (notice that pod install takes 8 minutes currently):
- run:
name: Fetch CocoaPods Specs
command: |
curl https://cocoapods-specs.circleci.com/fetch-cocoapods-repo-from-s3.sh | bash -s cf
As we expand more across CircleCI I think it may may sense to share steps using CircleCI Orbs so we don't need to duplicate things like this.
jkmassel
added a commit
that referenced
this pull request
Jan 17, 2019
Per @jtreanor’s suggestion here: #44 (review)
Per @jtreanor’s suggestion here: #44 (review)
jkmassel
force-pushed
the
add/automated-testing
branch
from
31e8837 to
80bd733
Compare
jtreanor
approved these changes
Jan 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses CircleCI to validate that everything is working correctly.
Also fixes issues causing the builds to fail