This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Make the NUX button wordwrap so that iOS 12.4 users can read it #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ScoutHarris
suggested changes
Sep 10, 2020
Contributor
ScoutHarris
left a comment
ScoutHarris
left a comment
There was a problem hiding this comment.
Hey @mindgraffiti . There is a hidden tertiaryButton in that storyboard. The truncation probably doesn't happen a lot on it, but just in case, we probably should apply the fix there as well.
ScoutHarris
approved these changes
Sep 10, 2020
Contributor
Author
|
Thank you @ScoutHarris! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
WPiOS testing PR: wordpress-mobile/WordPress-iOS#14874
There is an issue where iOS 12.0+ users on smaller devices do not get proper font scaling. This is an iOS 12 issue that doesn't happen on iOS 13. Instead of attempting to force iOS 12 to use the correct font scaling, we're going to word-wrap the long text in the button so it can be successfully read by the user.
Note that the buttons in the prologue are different because the UL&S project had updated designs to work from.