Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Conversation

@jtreanor
Copy link
Contributor

@jtreanor jtreanor commented Jan 25, 2019

This updates the CircleCI Config to use the Orbs defined in https://github.com/wordpress-mobile/circleci-orbs. It now also tests the project as well as validating the podspec.

We will be able to re-use this simple config across the other library projects in wordpress-mobile.

Related to wordpress-mobile/WordPress-iOS#10892.

It also adds cocoapods-repo-update to the Podfile to ensure that specs are always up to date.

Copy link
Contributor

@jkmassel jkmassel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic!

:shipit:

One thing that we may want to address - in this file:

It says:

Run 'pod spec lint' on a provided .podspec file.

But we actually run pod lib lint 🙂

@jtreanor
Copy link
Contributor Author

@jkmassel Good point! I'll change that 😄

@jklausa
Copy link
Contributor

jklausa commented Jan 25, 2019

What's the difference between lib lint an spec lint?

@jkmassel
Copy link
Contributor

jkmassel commented Jan 25, 2019

lib lint checks to ensure that the library code in the local working directory passes tests.

spec lint downloads the most recent pod version it can find and validates that.

What that means is that if you do spec lint, you're not testing the version you're working on, you're testing the last release. Which in this case, isn't what you want :)

@jtreanor jtreanor merged commit f6bc1b8 into develop Jan 25, 2019
@jtreanor jtreanor deleted the circleci-orbs branch January 25, 2019 16:21
@jklausa
Copy link
Contributor

jklausa commented Jan 25, 2019

Thanks for the explanation!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants