Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

WordPressComSiteInfo: add properties and update parser #522

Merged
merged 6 commits into from
Nov 25, 2020
Merged

WordPressComSiteInfo: add properties and update parser #522

merged 6 commits into from
Nov 25, 2020

Conversation

@ctarda
Copy link
Contributor

@ctarda ctarda commented Nov 25, 2020 •
edited
Loading

Closes #521

Changes

  • Add some properties to WordPressComSiteInfo to provide more information related to the state of the Jetpack installation. This will be very helpful for WooCommerce
  • Update parser. It seems like the payload key mapping to url is urlAfterRedirects
  • Add tests to cover the parser

Testing

  • 👀 on the code
  • If CI is ✅ we should we good to go. This should not introduce any breaking changes to WP

@ctarda ctarda added the enhancement New feature or request label Nov 25, 2020
@ctarda ctarda self-assigned this Nov 25, 2020
ScoutHarris
ScoutHarris approved these changes Nov 25, 2020
View reviewed changes
Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The podspec version should be updated to "1.30.0-beta.1". After that, 👍 .

@ctarda
Copy link
Contributor Author

ctarda commented Nov 25, 2020

Thanks @ScoutHarris . I updated the podspec, now that CI is ✅ I'll merge.

@ctarda ctarda merged commit 098405e into develop Nov 25, 2020
@ctarda ctarda deleted the issue/521-siteinfo branch November 25, 2020 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mindgraffiti mindgraffiti Awaiting requested review from mindgraffiti

1 more reviewer

@ScoutHarris ScoutHarris ScoutHarris approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ctarda ctarda

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

WordPressComSiteInfo initializer is missing data

3 participants

@ctarda @ScoutHarris