Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Conversation

@ctarda
Copy link
Contributor

@ctarda ctarda commented Dec 1, 2020

Closes #531

Changes

  • A new implementation of the NavigationCommand protocol that pops a navigation command once. So the functionality would be equivalent to the Back button in a navigation controller.
  • A unit test

How to test

This does not introduce any breaking changes, so a ✅ on CI should be enough. That being said, it can be tested in conjunction with woocommerce/woocommerce-ios#3219

@ctarda ctarda added the enhancement New feature or request label Dec 1, 2020
@ctarda ctarda self-assigned this Dec 1, 2020
@ctarda ctarda changed the title Add a command to navigate back one setp Add a command to navigate back one step Dec 1, 2020
@ScoutHarris
Copy link
Contributor

The pod version needs to be bumped to 1.31.0-beta.

Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the pod version is fixed, :shipit: .

@ctarda ctarda merged commit a8b598e into develop Dec 2, 2020
@ctarda ctarda deleted the issue/531-pop-navigation branch December 2, 2020 01:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add navigation command to allow host apps to pop the navigation controller

3 participants