Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Conversation

@ctarda
Copy link
Contributor

@ctarda ctarda commented Dec 4, 2020

Closes #533
Ref: woocommerce/woocommerce-ios#3146

Changes

Building up upon the functionality implemented in PR #525 , this PR touches GetStartedViewController, so that:

  • When we detect an error after a user attempts log in with an email address, we would ask the host app if it wants to handle this error and intercept the navigation flow
  • If the host app wants to handle the error, we would insert the UI that the host app provides.
  • If the host app does not want to handle the error, we continue forward without changes in behaviour.
  • Bumped the version in the podspec

How to test

This PR does not break the public API, but it has the potential to introduce a bug in WordPress. There are two ways I would suggest to test the functionality:

  1. Test the corresponding PR in WooCommerce (Block sign ups to WordPress.com accounts. woocommerce/woocommerce-ios#3286). When users try to log in with a WordPress account and enter an email address that does not match a WP.com account, WooCommerce should insert custom UI.
  2. Test the same flow with WordPress. No behaviour should change and it should still be possible to sign up for a WP.com account. The easiest way to test this is testing the draft PR Point WPAuthenticator to the branch that allows host apps to block account creation WordPress-iOS#15435

Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tested with WPiOS draft PR
✅ Code

:shipit: !

@ctarda ctarda merged commit 0170c88 into develop Dec 7, 2020
@ctarda ctarda deleted the issue/no-wp-signup branch December 7, 2020 01:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow host apps to bail out of new account creation flow

3 participants