Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Conversation

@ctarda
Copy link
Contributor

@ctarda ctarda commented Dec 10, 2020

Closes #538
Ref: woocommerce/woocommerce-ios#3319

LoginPrologueViewController sets its background color to WordPressAuthenticatorUnifiedStyle.unifiedBackgroundColor.

For WooCommerce, we would need to be able to set the background color of the area where the action buttons sit extend to be as wide as the screen.

Changes

  • Added a new parameter to WordPressAuthenticatorUnifiedStyle with a value that defaults to viewControllerBackgroundColor.
  • Add some logic to LoginPrologueViewController to assign this new color and hide the blurred view. I don't love how this is implemented, but I am not sure there is a much better way to do it.

How to test

There are no changes to the API, but just in case I submitted a draft PR to WordPress that should prove that nothing breaks: wordpress-mobile/WordPress-iOS#15464 The best way to test this is:

@ctarda ctarda merged commit 9a25886 into develop Dec 10, 2020
@ctarda ctarda deleted the issue/538-prologue-bgcolor branch December 10, 2020 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make background of LoginPrologueViewController customizable

3 participants