This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Add a new style parameter for spinner color when NUXButton is disabled #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… button is disabled.
…ityIndicatorColor` for the spinner color when the button is disabled.
ScoutHarris
reviewed
Jan 14, 2021
WordPressAuthenticator.podspec
Outdated
| Pod::Spec.new do |s| | ||
| s.name = "WordPressAuthenticator" | ||
| s.version = "1.33.0" | ||
| s.version = "1.33.1-beta.1" |
Contributor
There was a problem hiding this comment.
We leave the patch version for hotfixes, so this should be 1.34.0-beta.1.
Contributor
Author
There was a problem hiding this comment.
Great catch! Updated the pod version in: 30084d9
ScoutHarris
approved these changes
Jan 14, 2021
Contributor
ScoutHarris
left a comment
ScoutHarris
left a comment
There was a problem hiding this comment.
Please see my comment about the pod version.
Otherwise, LGTM.
Contributor
Author
|
Thank you for the prompt review, Stephenie! Merging this now 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes woocommerce/woocommerce-ios#2716 and woocommerce/woocommerce-ios#3386
Why
In
NUXButton, the spinner color is set tostyle.secondaryTitleColorwhen the button is disabled. The samestyle.secondaryTitleColoris also used as the button title color when the button is secondary style and disabled - this usage fits its name "secondaryTitleColor" the most. Because of this parameter reuse and the design in WCiOS, the same colorsecondaryTitleColorresults in the spinner color not visible at all in WCiOS (example screenshot).Changes
This PR added a new parameter
WordPressAuthenticatorStyle.disabledButtonActivityIndicatorColorfor the spinner color when the button is disabled inNUXButton.Testing
WPiOS
Please check out this PR wordpress-mobile/WordPress-iOS#15639 - feel free to merge it later, or just test the changes and add the parameter the next time WPiOS updates the authenticator pod
WCiOS
Please check out this PR: woocommerce/woocommerce-ios#3472
Example screenshots
WPiOS
WCiOS