This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Allow customization of NUX button view shadows constraints #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This fixes an issue on the login prologue screen where the top shadow didn't reach all the way to the edges of the superview, as it was constrained to the edges of the button view.
Merged
4 tasks
Gio2018
approved these changes
Apr 2, 2021
Contributor
Gio2018
left a comment
Gio2018
left a comment
There was a problem hiding this comment.
just one minor comment, other than that 
!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where NUX button shadows were constrained to the edges of the NUX button view controller, which meant they may not extend all the way to the edges of the screen:
With the changes in this PR, you can now pass a
layoutGuideto instances ofNUXButtonViewControllerwhich it will use to reconfigure the leading and trailing constraints of the shadow view:I also checked other places in WPiOS where we use the NUX view to ensure that their shadows continued to work okay (or that they didn't show the shadow in the first place):
You can test these changes via the associated WordPress iOS PR.