This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Fixes a styling issue. #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
frosty
approved these changes
Apr 28, 2021
Contributor
frosty
left a comment
frosty
left a comment
There was a problem hiding this comment.
Can confirm navigation bar styles look correct in both light and dark mode 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a styling issue within the navigation bar (when embedded in a
LoginViewController), that would show the wrong color for text in nav bar buttons and titles.Related to wordpress-mobile/WordPress-iOS#16380
Known issues:
These will be tackled incrementally, to avoid holding this fix back.
Associated PRs
WPiOS: wordpress-mobile/WordPress-iOS#16389
Testing:
Follow the instructions in the associated WPiOS PR.