This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Add the ability to customize the NUXButton styles on the Login Prologue #592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WPiOS Related PR: wordpress-mobile/WordPress-iOS#16407
In order to achieve the design for the Jetpack Prologue screen I needed to be able to change the NUXButton style just for that view. But since the NUXButton relies on
WordPressAuthenticator.shared.stylethis was not possible.I updated the NUXButton to include a new
NUXButtonStylestyle struct that defines the 3 different states:normal,highlighted, anddisabled. This uses an internal struct calledButtonStylethat groups the style intobackgroundColor,borderColor, andtitleColor.I also added a new way to configure the style of the button, but will fallback to the "legacy" way if that is not used. This prevents the button from breaking for the other areas it is used in the app while adding new functionality.
Testing Steps