This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Feature/SearchTableViewCell loading indicator #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandroalonso
suggested changes
Jun 8, 2021
Contributor
leandroalonso
left a comment
leandroalonso
left a comment
There was a problem hiding this comment.
@nikola-milicevic One small comment.
Also, you may want to bump the podspec version https://github.com/wordpress-mobile/WordPressAuthenticator-iOS/blob/develop/WordPressAuthenticator.podspec#L3
It should be beta.2, then I can merge and generate a new lib version for you.
Contributor
Author
|
@leandroalonso thanks for the comments, I updated the code. |
leandroalonso
approved these changes
Jun 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds loading indicator to the
SearchTableViewCell.It is requested as an addition to this library, as part of solving this issue.
Video preview of the loader:
120724878-f7891880-c4d4-11eb-90ca-6a36da5e33f5.mp4