This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Log site address on errors. Bumps podspec version. #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScoutHarris
approved these changes
Jun 24, 2021
Contributor
ScoutHarris
left a comment
ScoutHarris
left a comment
There was a problem hiding this comment.
Tested with wordpress-mobile/WordPress-iOS#16747.
| } | ||
|
|
||
| // Intentionally log the attempted address on failures. | ||
| // It's not guarenteed to be included in the error object depending on the error. |
Contributor
There was a problem hiding this comment.
guarenteed - so close! 😄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intentionally logs the attempted URL when there is an error trying to connect to a site address, since not all errors include the address. This will help happiness engineers to troubleshoot issues with a site before responding to a help request.
This can be tested with the related WPiOS PR: wordpress-mobile/WordPress-iOS#16747
@ScoutHarris would you mind?