This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Redirect Terms and service to open the page in an external web view #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScoutHarris
approved these changes
Jul 22, 2021
Contributor
ScoutHarris
left a comment
ScoutHarris
left a comment
There was a problem hiding this comment.
Tested with wordpress-mobile/WordPress-iOS#16907.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/WordPress-iOS#14756
Testable in: wordpress-mobile/WordPress-iOS#16907
Description
This change updates the TOS page to open in an external web browser instead of opening in the app. This modified experience will now match the experience an Android user will have with the app and also matches the experience they would get if they selected "Help" followed by "WordPress Help Center"
Alternatives
I feel like the experience would be better if we kept them in the app. So I wanted to think about some alternative paths. The option that came to mind is that we could refactor this to use a WKWebView and inject CSS to hide the
wpcom-masterbar. Although I think that's an ok solution it is slightly more fragile so I wanted to at least raise the question.Ultimately I opted to go for simplicity since the pattern on Android is already defined this way.
@ScoutHarris @diegoreymendez since you two worked in this area last I wonder if you had any thoughts?