This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Issues/wpcom credentials change #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScoutHarris
approved these changes
Mar 20, 2019
Contributor
ScoutHarris
left a comment
ScoutHarris
left a comment
There was a problem hiding this comment.
Looks good, and tested with wordpress-mobile/WordPress-iOS#11294.
…ticator-iOS into issues/wpcom-credentials-change
Contributor
Author
|
Thanks @ScoutHarris! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
usernamefrom wpcom credentials.The motivation for this change is to allow log in with just an auth token, and letting the username be synced later with the rest of a user's account information.
To Test:
Run tests and ensure they pass.
Test the changes branch with the companion WPiOS PR.
Needs review: @ScoutHarris would you be game to look at this one?
cc @mindgraffiti @bummytime - FYI. I haven't looked to see how this impacts WooCommerce-iOS but its on my todos.