This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Make the domain searches instantaneous #620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frosty
approved these changes
Oct 6, 2021
Contributor
frosty
left a comment
frosty
left a comment
There was a problem hiding this comment.
Works for me! Just one small query here, up to you if you want to tweak it :) Don't forget to bump the podspec version.
frosty
approved these changes
Oct 6, 2021
diegoreymendez
deleted the
wordpress/17240-make-the-domain-instantaneous
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to
SearchTableViewCell.swift:liveSearchproperty that adds support for immediate / live searches. This property defaults tofalseto try to avoid affecting existing code.allowSpacesproperty that adds support for stripping whitespaces from the user's input. This property defaults tofalseto try to avoid affecting existing code.Testing:
To test this, use the WordPress iOS PR.
Make sure you can't input whitespaces. Make sure live searches work as expected.
Associated PRs:
WordPress iOS PR: wordpress-mobile/WordPress-iOS#17266