Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Conversation

@twstokes
Copy link
Contributor

@twstokes twstokes commented Jan 6, 2022

Related PR:

Before After
Mode 2 - Before Mode 2 and 4

Note: There's a follow-up PR to make the message match the button label.

Testing:

@twstokes twstokes force-pushed the feature/xml-rpc-errors branch from 6cb4964 to 86290bb Compare January 13, 2022 04:30
@twstokes twstokes changed the title Improve error description Improve error description for XML-RPC serialization failures Jan 13, 2022
@twstokes twstokes changed the title Improve error description for XML-RPC serialization failures Improve error description Jan 13, 2022
@twstokes twstokes added the enhancement New feature or request label Jan 13, 2022
@twstokes twstokes marked this pull request as ready for review January 13, 2022 06:03
@guarani guarani self-requested a review January 13, 2022 19:18
Copy link

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in wordpress-mobile/WordPress-iOS#17724 (review) and code changes look good!

@twstokes twstokes merged commit 97a835c into trunk Jan 18, 2022
@twstokes twstokes deleted the feature/xml-rpc-errors branch January 18, 2022 02:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants