This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Update CI image to Xcode 13 #634
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request ref: p1642478590115900-slack-CC7L49W13 cc @twstokes
What?
This PR updates the Buildkite
.pipeline.ymlto usexcode-13as the CI image.Why?
As
WordPressAuthenticatordepends onWordPressKit, andWordPressKithas started usingasyncin its4.46.0-beta.1version which requires Xcode 13 to be built by Xcode without errors during pod validation, we needed to update the CI image forWordPressAuthenticatorto Xcode 13 as well to match.This was a long overdue anyway.
How? (aka the
bundlerkerfuffle)Because of a version mismatch in bundler versions used in the image, described in Automattic/a8c-ci-toolkit-buildkite-plugin#16, I had to apply the same workarounds that @mokagio used in wordpress-mobile/WordPressKit-iOS#473 to make this work.
What's Next?
@twstokes Once this PR gets merged, update the GitHub Release to include this new PR in its "changelog" description, then republish the GitHub release — thus recreating the
1.43.0-beta.1tag and triggering a pod publication (which should not fail anymore this time).