This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Add Buildkite Test Analytics #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was recommended by `xcodebuild` in Xcode 13.4.1: > error: Cycle inside WordPressAuthenticator; building could produce unreliable results. > This usually can be resolved by moving the target's Headers build phase before Compile Sources. See https://buildkite.com/automattic/wordpress-authenticator-ios/builds/161#0182673e-31b8-4816-830f-778a14a54ad9/539-2766
crazytonyli
suggested changes
Aug 5, 2022
fastlane/Fastfile
Outdated
| buildlog_path: File.join(__dir__, '.build', 'logs'), | ||
| derived_data_path: File.join(__dir__, '.build', 'derived-data') | ||
| derived_data_path: File.join(__dir__, '.build', 'derived-data'), | ||
| output_style: 'raw' |
Contributor
There was a problem hiding this comment.
This change was for debugging, wasn't it? It should be okay to delete it now?
Contributor
Author
There was a problem hiding this comment.
Yes. Great catch, thank you! 🙇♂️
Contributor
Author
There was a problem hiding this comment.
Addressed by dropping the commit via interactive rebase 👌
crazytonyli
approved these changes
Aug 9, 2022
AliSoftware
added a commit
that referenced
this pull request
Aug 9, 2022
With the newer Xcode CI image introduced in #654, we need to install an even newer version of bundler to work around Automattic/a8c-ci-toolkit-buildkite-plugin#16. This was fixed by #mokagio in various places in the `pipeline.yml` back when he worked on #654, but the `publish-pod.sh` file was missed in this update of the workaround, so we're patching this here
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up Test Analytics.