This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Pass a custom error for invalid WP.com password errors #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For woocommerce/woocommerce-ios#7318
Description
In order to handle the invalid WP.com password errors for WCiOS local notifications experiment Iteration 3, a
source: SignInSourceis added toPasswordViewControllerand the remote error is passed to the delegate. No external navigation is expected at this point, so the completion blockauthenticationDelegate.handleErroris a no-op now.Impact to WPiOS
WPiOS does not handle errors in a custom way like WCiOS.
Testing steps
Please refer to the WCiOS draft PR to test the integration: woocommerce/woocommerce-ios#7422