Add WordPressSupportSourceTag for "Enter site address" screen
#672
Conversation
jaclync
left a comment
jaclync
left a comment
There was a problem hiding this comment.
LGTM after the pod version update 👍
WordPressAuthenticator.podspec
Outdated
| Pod::Spec.new do |s| | ||
| s.name = 'WordPressAuthenticator' | ||
| s.version = '2.3.0' | ||
| s.version = '2.3.1-beta.1' |
There was a problem hiding this comment.
As Oguz @ Platform9 mentioned in the last code freeze #670 (comment), we want to follow the version scheme by bumping the middle digit for a new release. The last digit is only for hotfix.
| s.version = '2.3.1-beta.1' | |
| s.version = '2.4.0-beta.1' |
There was a problem hiding this comment.
Thanks for sharing this. 🙏
Done in dcd1691
| get { | ||
| .loginSiteAddress | ||
| } |
There was a problem hiding this comment.
nit: could it be simplified:
| get { | |
| .loginSiteAddress | |
| } | |
| .loginSiteAddress |
it's also interesting that the loginSiteAddress case exists before but doesn't seem to be used before this PR?
There was a problem hiding this comment.
Simplified in 9ea47ec
it's also interesting that the loginSiteAddress case exists before but doesn't seem to be used before this PR?
It is used here, and it seems like the screen isn't being used anymore. I believe that this screen and other screens from that flow were deprecated after the unified login project. Internal ref - p91TBi-2FR-p2
|
Thanks for the review @jaclync! As we decided to use |
For woocommerce/woocommerce-ios#7553
Changes
In order to open custom web pages for login-related screens, we need to be able to identify the login screens from WC iOS. I decided to use the
WordPressSupportSourceTagto identify each login screen.WordPressSupportSourceTagtoSiteAddressViewControllerto identify the screen in WC iOS.Equatableconformance toWordPressSupportSourceTagin order to equate the values in WC iOS.Testing steps
Follow the testing instructions from woocommerce/woocommerce-ios#7553