Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Conversation

@selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Aug 26, 2022

Related to - woocommerce/woocommerce-ios#7572 and woocommerce/woocommerce-ios#7573

Changes

GetStartedViewController and SiteAddressViewController were using same Step values (.start)

This makes it impossible to differentiate between those two screens in analytics events.

Meanwhile, WC Android uses "enter_email_address" as Step value for Enter email screen (GetStartedViewController)

This PR introduces a new Step value "enter_email_address" and uses that for GetStartedViewController.

Testing instructions

Follow the instructions from woocommerce/woocommerce-ios#7573 to test this.

Copy link
Contributor

@jaclync jaclync left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

start is indeed quite vague. does Android also use a different step value for the site address SiteAddressViewController screen? feel free to keep it as it is so that it doesn't affect existing analytics.

@selanthiraiyan
Copy link
Contributor Author

does Android also use a different step value for the site address SiteAddressViewController screen? feel free to keep it as it is so that it doesn't affect existing analytics.

No, they use start in Android for this screen. i.e. The events are identical in iOS and Android for SiteAddressViewController screen.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants