This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Use a new Step value for Enter WPCOM email screen
#674
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to - woocommerce/woocommerce-ios#7572 and woocommerce/woocommerce-ios#7573
Changes
GetStartedViewControllerandSiteAddressViewControllerwere using sameStepvalues (.start)This makes it impossible to differentiate between those two screens in analytics events.
Meanwhile, WC Android uses "enter_email_address" as
Stepvalue for Enter email screen (GetStartedViewController)This PR introduces a new
Stepvalue "enter_email_address" and uses that forGetStartedViewController.Testing instructions
Follow the instructions from woocommerce/woocommerce-ios#7573 to test this.