This repository was archived by the owner on Feb 5, 2025. It is now read-only.
NUXButton configurable using UIAppearance #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nges like `FancyButton` does
Removes NUXSubmitButton class. Removes button background assets and generates button background images.
mindgraffiti
commented
Jul 3, 2018
| @@ -1,54 +1,285 @@ | |||
| import UIKit | |||
Contributor
Author
There was a problem hiding this comment.
The NUXButton file is a duplicate of FancyButton with the activity view add-on (in case you're wondering where this code originated from)
3 tasks
Contributor
Author
|
@jleandroperez or @ScoutHarris ready for review! |
Contributor
|
Okay, not sure what's going on, but i didn't close this PR!! |
Contributor
|
I'd like to take a look at this one. |
nheagy
reviewed
Jul 5, 2018
| @@ -1,20 +1,5 @@ | |||
| PODS: | |||
| - 1PasswordExtension (1.8.5) | |||
| - AFNetworking (3.2.1): | |||
Contributor
There was a problem hiding this comment.
Any idea why the Podfile.lock changed so much without any changes to the Podfile?
| /// A stylized button used by Login controllers. It also can display a `UIActivityIndicatorView`. | ||
| @objc open class NUXButton: NUXSubmitButton { | ||
| // MARK: - Configuration | ||
| fileprivate let horizontalInset: CGFloat = 20 |
Contributor
There was a problem hiding this comment.
Where did these config values go?
crazytonyli
added a commit
that referenced
this pull request
Nov 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was branched from
new-woo-apis.new-woo-apisit isn't compatible with WPiOS just yet and was breaking when I attempted to test the secondary button.This PR makes the NUXButton configurable using UIAppearance. To run a full test, check out the WCiOS PR instructions.