This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Make WordPressAuthenticator.bundle public #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2019
astralbodies
approved these changes
Apr 11, 2019
Contributor
astralbodies
left a comment
astralbodies
left a comment
There was a problem hiding this comment.
Definitely an elegant and simple solution! 
Contributor
Author
|
I'm going to cherry pick this into a 1.3.1 so only these changes are included in WPiOS. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
bundlevar inWordPressAuthenticatorpublic so that the bundle can be accessed from outside the framework.This will allow wordpress-mobile/WordPress-iOS#11444 to be fixed.