This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Add support for requesting account creation when sending auth magic link #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichamboushaba
force-pushed
the
magic-link-create-account
branch
from
bac645f to
ab26abe
Compare
hichamboushaba
force-pushed
the
magic-link-create-account
branch
from
ab26abe to
e952ebf
Compare
4 tasks
hafizrahman
approved these changes
Nov 18, 2024
hafizrahman
left a comment
hafizrahman
left a comment
There was a problem hiding this comment.
Code looks good as it's simply getting the latest change from WordPressKit and using the new function from there.
Contributor
I took over this PR fix the WordPressKit dependency wiring. I've enabled auto merge and will proceed to update WooCommerce to point to these changes once they land. |
1 task
mokagio
added a commit
to woocommerce/woocommerce-ios
that referenced
this pull request
Nov 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: woocommerce/woocommerce-ios#14419
This PR adds support for requesting the creation of the account when using
WordPressComAccountService/requestAuthenticationLink, this allows using the same WPCom endpoint for sending magic link to both existing and new accounts.Testing
Check woocommerce/woocommerce-ios#14431
CHANGELOG.mdif necessary.