[Woo Brand Update] Add more customization options to the prologue #867
Conversation
…lor and image Also adds support for different scaling options for the background
…roller Having the empty stackview causes issues with content hugging that results in a bigger buttons section than needed
| topStackView?.isHidden = true | ||
| bottomStackView?.isHidden = true |
There was a problem hiding this comment.
Before this, both stack views were shown even when they are empty, and for some reason this causes the button section to take more space than needed when the top layout doesn't dictate a specific sizing.
I'm not entirely sure about the cause here, but my basic understanding is that when the stackview is empty and shown, it doesn't report an intrinsic size, so AutoLayout doesn't know how much space to give it when the top view doesn't report a size either.
Anyway, regardless of the explanation, I think hiding the empty view is what we should do, and given this fixes the issue, it's just better.
(I tried setting a higher priority for the content hugging constraint for the button container, but it didn't have an effect).
| guard prologueViewBackgroundColor.cgColor == buttonsBackgroundColor.cgColor else { | ||
| buttonBlurEffectView.effect = UIBlurEffect(style: blurEffect) | ||
| return | ||
| } |
There was a problem hiding this comment.
This logic is old, we had it when we didn't allow client apps to control the blur effect, later, this ability was added. Also, this old logic was causing me an issue, since with the new design, we need to have the buttons background as .clear, which means the condition applies here, and it causes the blur to be shown even when it's not configured, removing the logic fixes the issue.
itsmeichigo
left a comment
itsmeichigo
left a comment
There was a problem hiding this comment.
Tested as part of woocommerce/woocommerce-ios#14773 and confirmed that the new changes work correctly in iPhone SE, iPhone 16 Plus and iPad Mini simulators ✅.
When wordpress-mobile/WordPressAuthenticator-iOS#867 was merged, I had already started working on folding WordPressAuthenticator and didn't sync with the team about it. This commit picks all the changes from that PR and copies them in one go into the local version of the WordPressAuthenticator codebase.
When wordpress-mobile/WordPressAuthenticator-iOS#867 was merged, I had already started working on folding WordPressAuthenticator and didn't sync with the team about it. This commit picks all the changes from that PR and copies them in one go into the local version of the WordPressAuthenticator codebase.
When wordpress-mobile/WordPressAuthenticator-iOS#867 was merged, I had already started working on folding WordPressAuthenticator and didn't sync with the team about it. This commit picks all the changes from that PR and copies them in one go into the local version of the WordPressAuthenticator codebase.
When wordpress-mobile/WordPressAuthenticator-iOS#867 was merged, I had already started working on folding WordPressAuthenticator and didn't sync with the team about it. This commit picks all the changes from that PR and copies them in one go into the local version of the WordPressAuthenticator codebase.
Needed for woocommerce/woomobile-private#385
This PR adds the following changes:
To be tested with woocommerce/woocommerce-ios#14773
CHANGELOG.mdif necessary.