Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Conversation

@jklausa
Copy link
Contributor

@jklausa jklausa commented Feb 21, 2019

Description

Should be second-to-last one of those :)

This time adding support for fetching summary visits/visitors/comments/likes inf

Testing Details

  • Please check here if your pull request includes additional test coverage.

Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed one itty bitty typo, but otherwise :shipit: !


// We have our own handrolled date format for data broken up on week basis.
// Example dates in this format are `2019W02W18` or `2019W02W11`.
// The structure is rougly `aaaaWbbWcc`, where:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo - rougly = roughly. I know, you hate when I actually read the comments. 😉

Oh, yea, thanks for adding these descriptive comments!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@jklausa jklausa merged commit c71c6c1 into develop Feb 22, 2019
@jklausa jklausa deleted the feature/fetching-visits branch February 22, 2019 21:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants