This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Apply some Swift 4 cleanup #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
force-pushed
the
issue/79-swift5-phase1
branch
from
52fd23c to
ccf4322
Compare
Author
|
@jklausa would you be willing to take a look at this? |
jklausa
approved these changes
Feb 25, 2019
Contributor
jklausa
left a comment
jklausa
left a comment
There was a problem hiding this comment.
Looks great!
Out of curiosity, are the fileprivate changes flagged by compiler or did you find them by hand?
Author
|
Thanks! I found these by searching; I'm not aware of a compiler-assisted way to do this. This would be a bit more daunting task for a larger project (e.g., WPiOS). |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refs #79. Before we create a branch to consider the transition to Swift 5, there is some low-hanging fruit related to Swift 4 that we could stand to tackle. This PR takes care of those:
SWIFT_VERSIONis set to 4.2 at both the project & target levels.fileprivatemembers asprivatewhere applicableTesting Details
Checkout the branch, confirm that it builds and existing tests pass.
Evaluate the
issue/wpkit-79-integrationbranch from WPiOS and confirm that it has no ill-effect.Please check here if your pull request includes additional test coverage.