This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Provide memberwise initializers for Stats Insights objects. #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerych
approved these changes
Mar 19, 2019
Contributor
aerych
left a comment
aerych
left a comment
There was a problem hiding this comment.
This being necessary seems like such an oversight on Apple's part 🤦♂️.
Looks good. I left a note about the podspec version to help avoid a conflict with another patch.
Otherwise 
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of Stats work in WPiOS, we need a way to map Stats object back and forth from Core Data to the format WPKit uses.
Due to the fact that WPKit is in a separate module from WPiOS "proper", we need to manually provide memberwise initialisers for those objects. This accomplishes that!