This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Xcode 10.2 compatibility #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
approved these changes
Mar 29, 2019
Contributor
jkmassel
left a comment
jkmassel
left a comment
There was a problem hiding this comment.
This all looks solid, and still works great in Xcode 10.1
| @@ -1,5 +1,4 @@ | |||
| source 'https://rubygems.org' do | |||
| gem 'cocoapods', '1.5.3' | |||
| gem 'cocoapods', '1.6.1' | |||
| public extension BlogJetpackSettingsServiceRemote { | ||
|
|
||
| public enum Keys { | ||
| enum Keys { |
Contributor
There was a problem hiding this comment.
I'm presuming these were removed because it's duplicate visibility given BlogJetpackSettingsServiceRemote is public?
Contributor
Author
There was a problem hiding this comment.
Yep. This was the warning:
5 tasks
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes a few updates to make WordPressKit compatible with Xcode 10.2:
It still works fine with Xcode 10.1.
Testing Details