Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Conversation

@jklausa
Copy link
Contributor

@jklausa jklausa commented May 23, 2019

Description

There was a bug in the implementation of StatsTimeIntervalData-based Stats entities that made the library ignore the limit parameter for StatsSummaryTimeIntervalData.

This fixes that.

Testing Details

Check out related WPiOS PR (wordpress-mobile/WordPress-iOS#11758) and verify that the library now respects the limit parameter`.

@jklausa jklausa requested a review from a user May 23, 2019 02:54
@jklausa jklausa self-assigned this May 23, 2019
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jklausa Branch builds, tests pass. Fix verified via the corresponding WPiOS PR. Thank you!

:shipit:

@jklausa jklausa merged commit 95d6ab5 into develop May 23, 2019
@jklausa jklausa deleted the bug/allow-specifying-limit-for-summary-queries branch May 23, 2019 17:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants