This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Fetching a post on successful update (removes long time TODO) #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added file for getPost since now we are calling that method from updatePost
Closed
1 task
aerych
approved these changes
Jun 24, 2019
Contributor
aerych
left a comment
aerych
left a comment
There was a problem hiding this comment.
Looks good! Ran tests and all pass. Tested the changes via wordpress-mobile/WordPress-iOS#11970 and was able to view previews from new drafts and when updating drafts.
!
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
currently in the success block returned from
wp.EditPostwe have TODO to fetch the updated post, ostensibly the same way we do in the create method, and return it rather than the captured post.This PR implements fetching the post.
On failure to fetch the post we do as we previously did and return the captured post.
Spun off of: wordpress-mobile/WordPress-iOS#11952 (comment)