This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Stats Insights: don't fail parsing unless critical data is missing. #169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
danielebogo
approved these changes
Jul 16, 2019
Contributor
danielebogo
left a comment
danielebogo
left a comment
There was a problem hiding this comment.
LGTM! I tested 12137 and it worked correctly!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes issues where parsing Insights json would fail if any piece of data was missing. This was overkill, and resulted in some stats not showing when they should.
Fixes #n/a
Testing Details
Can be tested with WPiOS PR wordpress-mobile/WordPress-iOS#12137.