This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Add method to create WP account with Apple ID #181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
frosty
approved these changes
Aug 21, 2019
Contributor
frosty
left a comment
frosty
left a comment
There was a problem hiding this comment.
One small comment on this one, otherwise all looks good 👍
| * | ||
| * @param token Token provided by Apple. | ||
| * @param email Apple email to use for new account. | ||
| * @param userName The username for the new account. Formed from the Apple ID fullname. |
Contributor
There was a problem hiding this comment.
I think this is the user's name, not their username? If so, could we update the comment to make this clear?
Contributor
Author
There was a problem hiding this comment.
Gah. Clearly I had the endpoint param name on my brain. I'll change it. Thanks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a method to create a WordPress account using Apple ID credentials.
Fixes #n/a
Testing Details
Can be tested with WPiOS PR: wordpress-mobile/WordPress-iOS#12350
Also related to WPAuth PR: wordpress-mobile/WordPressAuthenticator-iOS#116