This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Gravatar download: handle successful response for unknown user #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is no matching user.
This was referenced Apr 16, 2020
mindgraffiti
approved these changes
Apr 17, 2020
Contributor
mindgraffiti
left a comment
mindgraffiti
left a comment
There was a problem hiding this comment.
This reminds me of Giorgio's comment, "the pods graph is not linear". 😀
✅ code
✅ tested with WPiOS test branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref #wordpress-mobile/WordPress-iOS#11771
This handles the case where Gravatar would return a successful response, but there was no user matching the email address.
Previously, this case was not handled and thus the caller received no response. Now the
failurecallback is called.Testing Details
Can be tested with WPiOS: wordpress-mobile/WordPress-iOS#13917