This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Support for custom domains. #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change we are allowing to set "include_wordpressdotcom", "only_wordpressdotcom". Their default values remain as true.
danielebogo
reviewed
Oct 11, 2018
| "only_wordpressdotcom": true as AnyObject] | ||
| } | ||
| return result | ||
| } |
Contributor
There was a problem hiding this comment.
Could every case return directly the [String: AnyObject]? Also could the function be private?
danielebogo
reviewed
Oct 11, 2018
| throw DecodingError.dataCorruptedError( | ||
| in: container, | ||
| debugDescription: "Cannot decode date string \(dateStr)" | ||
| ) |
Contributor
There was a problem hiding this comment.
Could the if let be guard let date ... and throw the error? So we can return the date after it without the if else statement.
Contributor
|
Hey @jklausa I only left 2 comments, but it looks great so far! |
Contributor
Author
|
uhh not what i was going for exactly here |
Contributor
|
Hey @jklausa |
Contributor
Author
|
@aerych GitHub is having some weird hiccups lately — I've addressed those way back when, but it's not showing in the inline diffs — you have to go to "Files changed" up top to see it :) |
Contributor
Author
:)?
Contributor
|
Fo sho! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This his mostly contents of #25, which was mostly reviewed already by me and @ScoutHarris before — just with some minor cleanups and with latest
developmerged in.I'm gonna leave it open after the review for a while, since it's possible I might need to do some changes while working on the WPiOS part of it, but it's close enough where I thought another pair of eyes wouldn't hurt :)