Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Conversation

@ghost
Copy link

@ghost ghost commented Oct 18, 2018

With the update to WordPressShared, we also need to increment this podspec dependency.

@ghost ghost requested a review from ctarda October 18, 2018 02:50
Copy link
Contributor

@ctarda ctarda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ctarda
Copy link
Contributor

ctarda commented Oct 18, 2018

Actually, @stevebaranski , the build failed locally with a cocoapods error.

@ctarda
Copy link
Contributor

ctarda commented Oct 18, 2018

🤔 pod install --repo-update seems to solve it though

@ghost ghost merged commit 4d61f0e into develop Oct 18, 2018
@ghost ghost deleted the fix/podspec-wpshared branch October 18, 2018 03:36
@nheagy
Copy link
Contributor

nheagy commented Oct 19, 2018

Just wanted to drop a note that we lost the ~> in this PR, making the WordPressShared dependency version fixed.

@ghost
Copy link
Author

ghost commented Oct 22, 2018

@nheagy thanks for bring this up. Hopefully our discussion via p77Llu-b8E-p2 will prevent future recurrences.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants