Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Conversation

@nheagy
Copy link
Contributor

@nheagy nheagy commented Oct 19, 2018

This adds ~> to the Podfile and podspec so that we can update the WordPressShared pod independently of this one.

To test:

  • In WPiOS change the Podfile to use this for WordPressKit: pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :commit => 'cc932dd33bcbee94a4c86ddd6fe8def350321e53'
  • Verify pod install still works
  • Verify the app still builds

@nheagy nheagy added the bug Something isn't working label Oct 19, 2018
@nheagy nheagy self-assigned this Oct 19, 2018
@nheagy nheagy requested a review from ScoutHarris October 19, 2018 22:39
Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated podfile as suggested. WPiOS works just fine. :shipit:

@nheagy
Copy link
Contributor Author

nheagy commented Oct 19, 2018

Thanks @ScoutHarris!

@nheagy nheagy merged commit 4250b7f into develop Oct 19, 2018
@nheagy nheagy deleted the fix/shared-pod-dependency branch February 19, 2019 16:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants