This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Comments: Parse author dotcom ID #469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 25, 2021
frosty
approved these changes
Nov 29, 2021
Contributor
frosty
left a comment
frosty
left a comment
There was a problem hiding this comment.
Looks good! Don't forget to update the WPiOS PR with the beta pod once released :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an
authorIDfield forRemoteCommentand updatesCommentServiceRemoteRESTto properly parse theauthorIDvalue from the API. Previously, this was not done before due to a bug where the comments endpoint would always return0for the author ID, regardless of role.Testing Details
Refer to the testing steps detailed in wordpress-mobile/WordPress-iOS#17566.