Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Show meaningful error when xmlrpc broken#48

Merged
ScoutHarris merged 7 commits intodevelopfrom
fix/show_meaningful_error_when_xmlrpc_broken
Oct 24, 2018
Merged

Show meaningful error when xmlrpc broken#48
ScoutHarris merged 7 commits intodevelopfrom
fix/show_meaningful_error_when_xmlrpc_broken

Conversation

@ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Oct 23, 2018

Fixes WPiOS wordpress-mobile/WordPress-iOS#10293

This does two things:

  1. Updates the non-WP site message to match Android.
  2. Adds another validation error case that displays a message specifically for WP sites where XML-RPC is not set up correctly.

Can be fully tested on WPiOS PR wordpress-mobile/WordPress-iOS#10308.

Copy link
Contributor

@aerych aerych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya @ScoutHarris ! Tested as described. Test sites were the sample customer site you gave me and google.com. Everything worked. :)
:shipit:

@ScoutHarris ScoutHarris merged commit cd55dfe into develop Oct 24, 2018
@ScoutHarris ScoutHarris deleted the fix/show_meaningful_error_when_xmlrpc_broken branch October 24, 2018 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants