This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Add invalidQuery error to WordPressComRestApiError #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ovitrif
approved these changes
Mar 7, 2022
Contributor
ovitrif
left a comment
ovitrif
left a comment
There was a problem hiding this comment.
Thank you for this PR Matthew!
The code LGTM, thank you for adding the test!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: WordPress-iOS/17985
Description
This adds
invalidQuery("invalid_query") to theWordPressComRestApiErrorenum. This is used to detect invalid domain queries when unsupported characters are present in the query string.Fixes wordpress-mobile/WordPress-iOS#15155
Testing Details
Manually test via the related PR, and also optionally run the automated tests added here.
versionin the.podspecfile.