Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Conversation

@jtreanor
Copy link
Contributor

@jtreanor jtreanor commented Nov 5, 2018

1.4.2.1 depends on WordPressShared version 1.3.0 but 1.4.3-beta.4 depends on 1.2.0. This is preventing us from merging back the latest release branch of WordPress iOS.

This is a simple version bump to resolve the conflict.

@jtreanor jtreanor requested a review from loremattei November 5, 2018 11:40
Copy link
Contributor

@loremattei loremattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since WordPressShared adds just a few events, I think there's no harm in shipping it. :-)
cc/ing @diegoreymendez

@jtreanor jtreanor merged commit d243f56 into develop Nov 5, 2018
@jtreanor jtreanor deleted the bump-143-beta5 branch November 5, 2018 11:51
@diegoreymendez
Copy link
Contributor

diegoreymendez commented Nov 5, 2018

@jtreanor - I had a pending task to merge back my changes into develop, master, and the new releases... thanks for taking care! (and sorry for the inconvenience!)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants