This repository was archived by the owner on Sep 15, 2025. It is now read-only.
[Site creation] Implementation of segments service #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Podfile.lock # WordPressKit.podspec
ghost
reviewed
Jan 22, 2019
| @@ -1,6 +1,6 @@ | |||
| Pod::Spec.new do |s| | |||
| s.name = "WordPressKit" | |||
| s.version = "1.7.0" | |||
There was a problem hiding this comment.
I'm not sure we should be updating the patch version in this case. It seems like we should be updating the minor version, yes?
ghost
reviewed
Jan 22, 2019
| case failure(SiteSegmentsError) | ||
| } | ||
|
|
||
| public struct SiteSegmentsRequest: Encodable { |
There was a problem hiding this comment.
Incidentally, I created this issue to address the apparent duplication of the locale parameter.
ghost
reviewed
Jan 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements part of issue #10316 in WordPress-iOS
In this PR:
To review: