This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Modified locale handling to inspect request parameters #80
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,167 @@ | ||
| import Foundation | ||
| import XCTest | ||
|
|
||
| import WordPressShared | ||
| @testable import WordPressKit | ||
|
|
||
| extension WordPressComRestApiTests { | ||
|
|
||
| func testThatAppendingLocaleWorks() { | ||
| // Given | ||
| let path = "/path/path" | ||
| let preferredLanguageIdentifier = WordPressComLanguageDatabase().deviceLanguage.slug | ||
|
|
||
| // When | ||
| let localeAppendedPath = WordPressComRestApi().buildRequestURLFor(path: path) | ||
|
|
||
| // Then | ||
| XCTAssertNotNil(localeAppendedPath) | ||
| let actualURL = URL(string: localeAppendedPath!, relativeTo: URL(string: WordPressComRestApi.apiBaseURLString)) | ||
| XCTAssertNotNil(actualURL) | ||
|
|
||
| let actualURLComponents = URLComponents(url: actualURL!, resolvingAgainstBaseURL: false) | ||
| XCTAssertNotNil(actualURLComponents) | ||
|
|
||
| let expectedPath = path | ||
| let actualPath = actualURLComponents!.path | ||
| XCTAssertEqual(expectedPath, actualPath) | ||
|
|
||
| let actualQueryItems = actualURLComponents!.queryItems | ||
| XCTAssertNotNil(actualQueryItems) | ||
|
|
||
| let expectedQueryItemCount = 1 | ||
| let actualQueryItemCount = actualQueryItems!.count | ||
| XCTAssertEqual(expectedQueryItemCount, actualQueryItemCount) | ||
|
|
||
| let actualQueryItem = actualQueryItems!.first | ||
| XCTAssertNotNil(actualQueryItem!) | ||
|
|
||
| let actualQueryItemKey = actualQueryItem!.name | ||
| let expectedQueryItemKey = WordPressComRestApi.localeKey | ||
| XCTAssertEqual(expectedQueryItemKey, actualQueryItemKey) | ||
|
|
||
| let actualQueryItemValue = actualQueryItem!.value | ||
| XCTAssertNotNil(actualQueryItemValue) | ||
|
|
||
| let expectedQueryItemValue = preferredLanguageIdentifier | ||
| XCTAssertEqual(expectedQueryItemValue, actualQueryItemValue!) | ||
| } | ||
|
|
||
| func testThatAppendingLocaleWorksWithExistingParams() { | ||
| // Given | ||
| let path = "/path/path" | ||
| let params: [String: AnyObject] = [ | ||
| "someKey": "value" as AnyObject | ||
| ] | ||
|
|
||
| // When | ||
| let localeAppendedPath = WordPressComRestApi().buildRequestURLFor(path: path, parameters: params) | ||
|
|
||
| // Then | ||
| XCTAssertNotNil(localeAppendedPath) | ||
| let actualURL = URL(string: localeAppendedPath!, relativeTo: URL(string: WordPressComRestApi.apiBaseURLString)) | ||
| XCTAssertNotNil(actualURL) | ||
|
|
||
| let actualURLComponents = URLComponents(url: actualURL!, resolvingAgainstBaseURL: false) | ||
| XCTAssertNotNil(actualURLComponents) | ||
|
|
||
| let expectedPath = "/path/path" | ||
| let actualPath = actualURLComponents!.path | ||
| XCTAssertEqual(expectedPath, actualPath) | ||
|
|
||
| let actualQueryItems = actualURLComponents!.queryItems | ||
| XCTAssertNotNil(actualQueryItems) | ||
|
|
||
| let expectedQueryItemCount = 1 | ||
| let actualQueryItemCount = actualQueryItems!.count | ||
| XCTAssertEqual(expectedQueryItemCount, actualQueryItemCount) | ||
|
|
||
| let actualQueryString = actualURLComponents?.query | ||
| XCTAssertNotNil(actualQueryString) | ||
|
|
||
| let queryStringIncludesLocale = actualQueryString!.contains(WordPressComRestApi.localeKey) | ||
| XCTAssertTrue(queryStringIncludesLocale) | ||
| } | ||
|
|
||
| func testThatLocaleIsNotAppendedIfAlreadyIncludedInPath() { | ||
| // Given | ||
| let preferredLanguageIdentifier = "foo" | ||
| let path = "/path/path?locale=\(preferredLanguageIdentifier)" | ||
|
|
||
| // When | ||
| let localeAppendedPath = WordPressComRestApi().buildRequestURLFor(path: path) | ||
|
|
||
| // Then | ||
| XCTAssertNotNil(localeAppendedPath) | ||
| let actualURL = URL(string: localeAppendedPath!, relativeTo: URL(string: WordPressComRestApi.apiBaseURLString)) | ||
| XCTAssertNotNil(actualURL) | ||
|
|
||
| let actualURLComponents = URLComponents(url: actualURL!, resolvingAgainstBaseURL: false) | ||
| XCTAssertNotNil(actualURLComponents) | ||
|
|
||
| let expectedPath = "/path/path" | ||
| let actualPath = actualURLComponents!.path | ||
| XCTAssertEqual(expectedPath, actualPath) | ||
|
|
||
| let actualQueryItems = actualURLComponents!.queryItems | ||
| XCTAssertNotNil(actualQueryItems) | ||
|
|
||
| let expectedQueryItemCount = 1 | ||
| let actualQueryItemCount = actualQueryItems!.count | ||
| XCTAssertEqual(expectedQueryItemCount, actualQueryItemCount) | ||
|
|
||
| let actualQueryItem = actualQueryItems!.first | ||
| XCTAssertNotNil(actualQueryItem!) | ||
|
|
||
| let actualQueryItemKey = actualQueryItem!.name | ||
| let expectedQueryItemKey = WordPressComRestApi.localeKey | ||
| XCTAssertEqual(expectedQueryItemKey, actualQueryItemKey) | ||
|
|
||
| let actualQueryItemValue = actualQueryItem!.value | ||
| XCTAssertNotNil(actualQueryItemValue) | ||
|
|
||
| let expectedQueryItemValue = preferredLanguageIdentifier | ||
| XCTAssertEqual(expectedQueryItemValue, actualQueryItemValue!) | ||
| } | ||
|
|
||
| func testThatAppendingLocaleIgnoresIfAlreadyIncludedInRequestParameters() { | ||
| // Given | ||
| let inputPath = "/path/path" | ||
| let expectedLocaleValue = "foo" | ||
| let params: [String : AnyObject] = [ | ||
| WordPressComRestApi.localeKey: expectedLocaleValue as AnyObject | ||
| ] | ||
|
|
||
| // When | ||
| let requestURLString = WordPressComRestApi().buildRequestURLFor(path: inputPath, parameters: params) | ||
|
|
||
| // Then | ||
| let preferredLanguageIdentifier = WordPressComLanguageDatabase().deviceLanguage.slug | ||
| XCTAssertFalse(requestURLString!.contains(preferredLanguageIdentifier)) | ||
| } | ||
|
|
||
| func testThatLocaleIsNotAppendedWhenDisabled() { | ||
| // Given | ||
| let path = "/path/path" | ||
|
|
||
| // When | ||
| let api = WordPressComRestApi() | ||
| api.appendsPreferredLanguageLocale = false | ||
| let localeAppendedPath = api.buildRequestURLFor(path: path) | ||
|
|
||
| // Then | ||
| XCTAssertNotNil(localeAppendedPath) | ||
| let actualURL = URL(string: localeAppendedPath!, relativeTo: URL(string: WordPressComRestApi.apiBaseURLString)) | ||
| XCTAssertNotNil(actualURL) | ||
|
|
||
| let actualURLComponents = URLComponents(url: actualURL!, resolvingAgainstBaseURL: false) | ||
| XCTAssertNotNil(actualURLComponents) | ||
|
|
||
| let expectedPath = path | ||
| let actualPath = actualURLComponents!.path | ||
| XCTAssertEqual(expectedPath, actualPath) | ||
|
|
||
| let actualQueryItems = actualURLComponents!.queryItems | ||
| XCTAssertNil(actualQueryItems) | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.